Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests and DMAPI fix #1675

Merged
merged 8 commits into from
Oct 21, 2023
Merged

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Oct 17, 2023

🆑 Interop API
Fixed TGS not sending the current security level or world visibility to DreamDaemon after a reattach.
/:cl:

🆑 DreamMaker API
Fixed world.TgsSecurityLevel() always returning null.
/:cl:

@Cyberboss Cyberboss added Area: DMAPI Communication between TGS and DM Regression Test We've seen this before, make sure it doesn't happen again labels Oct 17, 2023
@Cyberboss Cyberboss added this to the v5.16.3 milestone Oct 17, 2023
@Cyberboss Cyberboss enabled auto-merge October 17, 2023 02:44
github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 18, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 19, 2023
@Cyberboss Cyberboss added Fix Fixes incorrect functionality Component Issue Issue regarding the service components labels Oct 21, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 21, 2023
github-actions[bot]
github-actions bot previously approved these changes Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1675 (279671c) into master (c11afb5) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 92.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1675   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         606      606           
  Lines      126542   126542           
  Branches     2790     2788    -2     
=======================================
+ Hits       120128   120136    +8     
+ Misses       5934     5926    -8     
  Partials      480      480           

@Cyberboss Cyberboss merged commit 83117cf into master Oct 21, 2023
96 checks passed
@Cyberboss Cyberboss deleted the FuckYouDD-UnresolvesYourSymlinks branch October 21, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: DMAPI Communication between TGS and DM Component Issue Issue regarding the service components Fix Fixes incorrect functionality Regression Test We've seen this before, make sure it doesn't happen again
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant