-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression tests and DMAPI fix #1675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
added
Area: DMAPI
Communication between TGS and DM
Regression Test
We've seen this before, make sure it doesn't happen again
labels
Oct 17, 2023
Cyberboss
force-pushed
the
FuckYouDD-UnresolvesYourSymlinks
branch
from
October 17, 2023 02:59
24a9cf5
to
809d849
Compare
Cyberboss
force-pushed
the
FuckYouDD-UnresolvesYourSymlinks
branch
from
October 18, 2023 12:59
fa45cce
to
3edb997
Compare
Cyberboss
added
Fix
Fixes incorrect functionality
Component Issue
Issue regarding the service components
labels
Oct 21, 2023
Cyberboss
force-pushed
the
FuckYouDD-UnresolvesYourSymlinks
branch
from
October 21, 2023 04:02
61da636
to
a6cb819
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1675 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 606 606
Lines 126542 126542
Branches 2790 2788 -2
=======================================
+ Hits 120128 120136 +8
+ Misses 5934 5926 -8
Partials 480 480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: DMAPI
Communication between TGS and DM
Component Issue
Issue regarding the service components
Fix
Fixes incorrect functionality
Regression Test
We've seen this before, make sure it doesn't happen again
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑 Interop API
Fixed TGS not sending the current security level or world visibility to DreamDaemon after a reattach.
/:cl:
🆑 DreamMaker API
Fixed
world.TgsSecurityLevel()
always returningnull
./:cl: